Things about Ch7 lab1
Finally passed all test in this lab. I'd like to share some points about this lab.
- The version of
got
used in our tutorials sticks with@11
. Maybe the reason is that the latest version ofgot
- version 12 was still under development when tutorials were under drafting. With version 11.8.3 , it seems thattimeout
option for got is not respected during the execution of my code. So I raised this issue on github. I triedtimeout
option in order to match this criteria:
Be sure that if an upstream service is not available, that the service responds within1250ms.
It seems that got will retry 3 times with 1000ms as interval by default.
The solution to bypass this criteria currently is to set retry
to 0 .
Although this workaround helps me to pass the lab, but it is still not very doable in practice. Because retry of requests and controlling of the period of retry are very necessary in many scenarios.
- It looks like that the implemention of the validation will print all fastify log to the console. For example:
{"level":30,"time":1647899897407,"pid":15410,"hostname":"3855b2c37774","msg":"Server listening at http://0.0.0.0:3000"}
{"level":30,"time":1647899897677,"pid":15410,"hostname":"3855b2c37774","reqId":"req-1","req":> {"method":"GET","url":"/1","hostname":"localhost:3000","remoteAddress":"127.0.0.1","remotePort":58880},"msg":"incoming request"}
{"level":30,"time":1647899897700,"pid":15410,"hostname":"3855b2c37774","reqId":"req-1","res":{"statusCode":200},"responseTime":22.886099999770522,"msg":"request completed"}
☑️ GET http://localhost:3000/1 responded with 200 response
If you would like to hide these log, you can comment out the 81th line stdio: 'inherit',
.
Comments
-
After digging into documents of got for a while, I noticed that
timeout
is used for the time got spends to wait for a response from a server. Due to the upstream service is not available at all, the bad response will be received by got in no time. Sotimeout
option is not applicable in this scenario.Maybe you will ask, if response come back to
got
in no time, what causes the delay betweengot()
invocation and error being caught.The answer is the retry mechanism of retry.
You can find more details from here.Basically got will retry twice by default if error occurs when using got to send request. There will be a delay before each retry. There is an option
retry.calculateDelay
which determines the retry behavior of got. It is a function whose return valure will be the delay before each retry. If the return value is 0, then there will be no more retry and the promise returned bygot()
invocation will be rejected.There is also a algorithm to calculate the default delay of each retry.
((2 ** (attemptCount - 1)) * 1000) + noise
That's why the total amount of time consumed by got until error being caught is around 3000 ms, which does not match our test criteria and leads to a test failure.
I change the
retry.calculateDelay
from({computedValue}) => computedValue
toretry: { calculateDelay: () => { const current = performance.now() const delay = (current - start + retryInterval > mustThrowWithinThisPeriodIfAnyError) ? 0 : retryInterval console.log(current - start, mustThrowWithinThisPeriodIfAnyError, retryInterval); return delay } }
current - start + retryInterval
will let me know if I continue to next retry, whether the time consumed by thisgot()
invocation will exceed the limitation set by the criteria of the lab. If not, then continue to next retry, otherwise return 0 from this function to canel next retry and end the retry behavior of got.The full version code of root route is
'use strict' const got = require('got') const { BOAT_SERVICE_PORT, BRAND_SERVICE_PORT } = process.env module.exports = async function (fastify, opts) { const { notFound, badRequest } = fastify.httpErrors fastify.get('/:id', async function (request, reply) { const { id } = request.params try { const { brand: brandId, color } = await gotWrapper(BOAT_SERVICE_PORT, id, 1250, 500) const { name: brand } = await gotWrapper(BRAND_SERVICE_PORT, brandId, 1250, 500) return { id: Number(id), color, brand } } catch (err) { if (err.response) { if (err.response.statusCode === 404) { throw notFound() } if (err.response.statusCode === 400) { throw badRequest() } throw err } throw err } }) } const gotWrapper = async (port, path, mustThrowWithinThisPeriodIfAnyError, retryInterval = 1000) => { const start = performance.now() return await got(`http://localhost:${port}/${path}`, { retry: { calculateDelay: () => { const current = performance.now() const delay = (current - start + retryInterval > mustThrowWithinThisPeriodIfAnyError) ? 0 : retryInterval console.log(current - start, mustThrowWithinThisPeriodIfAnyError, retryInterval); return delay } } }).json() }
All tests will be passed meanwhile got will retry to send request in a relatively short period which is more realistic in our daily program.
1 -
excellent deep dive
0 -
Great deep dive,
For this lab exercise, I had a simple solution, make the retry 0 and smaller timeout for got
const gotOptions ={
retry: {
limit:0
},
timeout: {
request: 50
}
}
const boatRes = await got(${BOAT_URL}/${id}
, gotOptions).json();0
Categories
- All Categories
- 60 LFX Mentorship
- 113 LFX Mentorship: Linux Kernel
- 618 Linux Foundation IT Professional Programs
- 321 Cloud Engineer IT Professional Program
- 142 Advanced Cloud Engineer IT Professional Program
- 55 DevOps Engineer IT Professional Program
- 68 Cloud Native Developer IT Professional Program
- 6 Express Training Courses
- 6 Express Courses - Discussion Forum
- 2.3K Training Courses
- 19 LFC110 Class Forum - Discontinued
- 9 LFC131 Class Forum
- 31 LFD102 Class Forum
- 175 LFD103 Class Forum
- 22 LFD121 Class Forum
- 2 LFD137 Class Forum
- 61 LFD201 Class Forum
- 2 LFD210 Class Forum
- 1 LFD210-CN Class Forum
- 1 LFD213 Class Forum - Discontinued
- 128 LFD232 Class Forum - Discontinued
- LFD237 Class Forum
- 23 LFD254 Class Forum
- 653 LFD259 Class Forum
- 108 LFD272 Class Forum
- 1 LFD272-JP クラス フォーラム
- 4 LFD273 Class Forum
- 2 LFS145 Class Forum
- 28 LFS200 Class Forum
- 740 LFS201 Class Forum - Discontinued
- 1 LFS201-JP クラス フォーラム
- 12 LFS203 Class Forum
- 92 LFS207 Class Forum
- 301 LFS211 Class Forum
- 54 LFS216 Class Forum
- 47 LFS241 Class Forum
- 41 LFS242 Class Forum
- 37 LFS243 Class Forum
- 12 LFS244 Class Forum
- 41 LFS250 Class Forum
- 1 LFS250-JP クラス フォーラム
- LFS251 Class Forum
- 142 LFS253 Class Forum
- LFS254 Class Forum
- LFS255 Class Forum
- LFS256 Class Forum
- LFS257 Class Forum
- 1.2K LFS258 Class Forum
- 10 LFS258-JP クラス フォーラム
- 106 LFS260 Class Forum
- 145 LFS261 Class Forum
- 39 LFS262 Class Forum
- 83 LFS263 Class Forum - Discontinued
- 15 LFS264 Class Forum - Discontinued
- 11 LFS266 Class Forum - Discontinued
- 20 LFS267 Class Forum
- 18 LFS268 Class Forum
- 26 LFS269 Class Forum
- 204 LFS272 Class Forum
- 1 LFS272-JP クラス フォーラム
- LFS274 Class Forum
- 3 LFS281 Class Forum
- 249 LFW211 Class Forum
- 177 LFW212 Class Forum
- 9 SKF100 Class Forum
- SKF200 Class Forum
- 907 Hardware
- 220 Drivers
- 74 I/O Devices
- 44 Monitors
- 116 Multimedia
- 210 Networking
- 102 Printers & Scanners
- 86 Storage
- 764 Linux Distributions
- 88 Debian
- 66 Fedora
- 15 Linux Mint
- 13 Mageia
- 24 openSUSE
- 143 Red Hat Enterprise
- 33 Slackware
- 13 SUSE Enterprise
- 357 Ubuntu
- 482 Linux System Administration
- 40 Cloud Computing
- 70 Command Line/Scripting
- Github systems admin projects
- 95 Linux Security
- 80 Network Management
- 108 System Management
- 51 Web Management
- 72 Mobile Computing
- 25 Android
- 32 Development
- 1.2K New to Linux
- 1.1K Getting Started with Linux
- 545 Off Topic
- 132 Introductions
- 223 Small Talk
- 22 Study Material
- 831 Programming and Development
- 282 Kernel Development
- 515 Software Development
- 974 Software
- 260 Applications
- 185 Command Line
- 3 Compiling/Installing
- 119 Games
- 318 Installation
- 65 All In Program
- 65 All In Forum
Upcoming Training
-
August 20, 2018
Kubernetes Administration (LFS458)
-
August 20, 2018
Linux System Administration (LFS301)
-
August 27, 2018
Open Source Virtualization (LFS462)
-
August 27, 2018
Linux Kernel Debugging and Security (LFD440)