Promisify based solution for lab 8.2 .

I have tried a promisify based solution to lab 8.2 .
Share with you.
Any additional advice is welcome.
Solution 1:
'use strict' const { promisify } = require('util') const print = (err, contents) => { if (err) console.error(err) else console.log(contents) } const opA = (cb) => { setTimeout(() => { cb(null, 'A') }, 500) } const opB = (cb) => { setTimeout(() => { cb(null, 'B') }, 250) } const opC = (cb) => { setTimeout(() => { cb(null, 'C') }, 125) } // solution 1 const printHelper = (contents) => print(null, contents) const pOpA = promisify(opA) const pOpB = promisify(opB) const pOpC = promisify(opC) pOpA() .then(printHelper) .then(() => pOpB()) .then(printHelper) .then(() => pOpC()) .then(printHelper)
Solution 2:
'use strict' const { promisify } = require('util') const print = (err, contents) => { if (err) console.error(err) else console.log(contents) } const opA = (cb) => { setTimeout(() => { cb(null, 'A') }, 500) } const opB = (cb) => { setTimeout(() => { cb(null, 'B') }, 250) } const opC = (cb) => { setTimeout(() => { cb(null, 'C') }, 125) } // solution 2 const pOpA = promisify(opA) const pOpB = promisify(opB) const pOpC = promisify(opC) const operate = async () => { print(null, await pOpA()) print(null, await pOpB()) print(null, await pOpC()) } operate()
Comments
-
Hi,
I followed the .then approach according to the training Promises (Cont.) chapter where we want to execute serial each function.
const contentA = promisify(opA)
const contentB = promisify(opB)
const contentC = promisify(opC)contentA()
.then((contents) => {
print(contents)
return contentB()
})
.then((contents) => {
print (contents)
return contentC()
})
.then(print)0 -
@ghortat said:
Hi,I followed the .then approach according to the training Promises (Cont.) chapter where we want to execute serial each function.
const contentA = promisify(opA)
const contentB = promisify(opB)
const contentC = promisify(opC)contentA()
.then((contents) => {
print(contents)
return contentB()
})
.then((contents) => {
print (contents)
return contentC()
})
.then(print)That looks similar as mine. I abstracted the print function into a printHelper to make the code compact.
0 -
@krave said:
@ghortat said:
Hi,I followed the .then approach according to the training Promises (Cont.) chapter where we want to execute serial each function.
const contentA = promisify(opA)
const contentB = promisify(opB)
const contentC = promisify(opC)contentA()
.then((contents) => {
print(contents)
return contentB()
})
.then((contents) => {
print (contents)
return contentC()
})
.then(print)That looks similar as mine. I abstracted the print function into a printHelper to make the code compact.
You actually don't need to abstract the print function
const { promisify } = require("util"); const print = (err, contents) => { if (err) console.error(err); else console.log(contents); }; const opA = (cb) => { setTimeout(() => { cb(null, "A"); }, 500); }; const opB = (cb) => { setTimeout(() => { cb(null, "B"); }, 250); }; const opC = (cb) => { setTimeout(() => { cb(null, "C"); }, 125); }; const opAProm = promisify(opA); const opBProm = promisify(opB); const opCProm = promisify(opC); opAProm() .then(print) .then(() => opBProm()) .then(print) .then(() => opCProm()) .then(print);
0 -
@nosvalds said:
@krave said:
@ghortat said:
Hi,I followed the .then approach according to the training Promises (Cont.) chapter where we want to execute serial each function.
const contentA = promisify(opA)
const contentB = promisify(opB)
const contentC = promisify(opC)contentA()
.then((contents) => {
print(contents)
return contentB()
})
.then((contents) => {
print (contents)
return contentC()
})
.then(print)That looks similar as mine. I abstracted the print function into a printHelper to make the code compact.
You actually don't need to abstract the print function
const { promisify } = require("util"); const print = (err, contents) => { if (err) console.error(err); else console.log(contents); }; const opA = (cb) => { setTimeout(() => { cb(null, "A"); }, 500); }; const opB = (cb) => { setTimeout(() => { cb(null, "B"); }, 250); }; const opC = (cb) => { setTimeout(() => { cb(null, "C"); }, 125); }; const opAProm = promisify(opA); const opBProm = promisify(opB); const opCProm = promisify(opC); opAProm() .then(print) .then(() => opBProm()) .then(print) .then(() => opCProm()) .then(print);
Hi, nosvalds
If you look close at the code and set a debugger in the print function. Run the code in debug mode and you will notice that the actual method which log out A, B, C is
console.error
.I believe the intention of this function is for whatever error occurs. Not the normal workflow. So I adjusted the handler.
1 -
Prefer async/await to .then and .catch because
- it allows for async stack traces (stack traces over multiple event loop ticks that trace the awaiting of promises in async functions)
- if you forget the .catch handler you end up with a unhandled rejection handler
- less code noise with async await + less chance of deep nesting
1 -
@davidmarkclements Thank you for your advices.
0
Categories
- 9.1K All Categories
- 15 LFX Mentorship
- 68 LFX Mentorship: Linux Kernel
- 382 Linux Foundation Boot Camps
- 234 Cloud Engineer Boot Camp
- 76 Advanced Cloud Engineer Boot Camp
- 30 DevOps Engineer Boot Camp
- 9 Cloud Native Developer Boot Camp
- 983 Training Courses
- 15 LFC110 Class Forum
- 16 LFD102 Class Forum
- 106 LFD103 Class Forum
- 6 LFD121 Class Forum
- 56 LFD201 Class Forum
- 1 LFD213 Class Forum - Discontinued
- 128 LFD232 Class Forum
- 19 LFD254 Class Forum
- 450 LFD259 Class Forum
- 90 LFD272 Class Forum
- 1 LFD272-JP クラス フォーラム
- 16 LFS200 Class Forum
- 715 LFS201 Class Forum
- LFS201-JP クラス フォーラム
- 283 LFS211 Class Forum
- 51 LFS216 Class Forum
- 27 LFS241 Class Forum
- 28 LFS242 Class Forum
- 19 LFS243 Class Forum
- 6 LFS244 Class Forum
- 12 LFS250 Class Forum
- LFS250-JP クラス フォーラム
- 113 LFS253 Class Forum
- 814 LFS258 Class Forum
- 8 LFS258-JP クラス フォーラム
- 54 LFS260 Class Forum
- 81 LFS261 Class Forum
- 18 LFS262 Class Forum
- 76 LFS263 Class Forum
- 15 LFS264 Class Forum
- 10 LFS266 Class Forum
- 10 LFS267 Class Forum
- 9 LFS268 Class Forum
- 6 LFS269 Class Forum
- 183 LFS272 Class Forum
- 1 LFS272-JP クラス フォーラム
- 191 LFW211 Class Forum
- 114 LFW212 Class Forum
- 880 Hardware
- 207 Drivers
- 74 I/O Devices
- 44 Monitors
- 115 Multimedia
- 205 Networking
- 98 Printers & Scanners
- 82 Storage
- 730 Linux Distributions
- 85 Debian
- 64 Fedora
- 12 Linux Mint
- 13 Mageia
- 22 openSUSE
- 127 Red Hat Enterprise
- 33 Slackware
- 13 SUSE Enterprise
- 349 Ubuntu
- 450 Linux System Administration
- 33 Cloud Computing
- 64 Command Line/Scripting
- Github systems admin projects
- 89 Linux Security
- 76 Network Management
- 105 System Management
- 45 Web Management
- 51 Mobile Computing
- 19 Android
- 19 Development
- 1.2K New to Linux
- 1.1K Getting Started with Linux
- 501 Off Topic
- 121 Introductions
- 193 Small Talk
- 19 Study Material
- 756 Programming and Development
- 243 Kernel Development
- 479 Software Development
- 903 Software
- 247 Applications
- 178 Command Line
- 2 Compiling/Installing
- 73 Games
- 314 Installation
- 26 All In Program
- 26 All In Forum
Upcoming Training
-
August 20, 2018
Kubernetes Administration (LFS458)
-
August 20, 2018
Linux System Administration (LFS301)
-
August 27, 2018
Open Source Virtualization (LFS462)
-
August 27, 2018
Linux Kernel Debugging and Security (LFD440)