Welcome to the Linux Foundation Forum!
Line discipline register and unregister in new kernels
rutigl
Posts: 1
I have a linux kernel driver for serial device, which uses line discipline and char device. Driver works with all old kernels, starting from 3.8 this driver still works, but when I unload it and load again to the memory (modprobe -r bpsctl_mod, after modprobe bpsctl_mod), it crashes the kernel. It can't unregister line discipline, because this line discipline is busy. I use system device, i.e., ttyS0. Here is problematic code:
static struct file* bps_file_open(const char* path, int flags, int rights) {
struct file* filp = NULL;
mm_segment_t oldfs;
oldfs = get_fs();
set_fs(get_ds());
filp = filp_open(path, flags, rights);
set_fs(oldfs);
if (IS_ERR(filp))
return NULL;
return filp;
}
int register_ldisc(void) {
int status;
// Fill in our line protocol discipline, and register it
extbp_drv.ebtty_ldisc.magic = TTY_LDISC_MAGIC;
extbp_drv.ebtty_ldisc.name = BP_LDISC_NAME;
extbp_drv.ebtty_ldisc.flags = 0;
extbp_drv.ebtty_ldisc.open = ebtty_open;
extbp_drv.ebtty_ldisc.close = ebtty_close;
extbp_drv.ebtty_ldisc.read = NULL;
extbp_drv.ebtty_ldisc.write = NULL;
extbp_drv.ebtty_ldisc.ioctl = (int (*)(struct tty_struct *, struct file *,
unsigned int, unsigned long)) ebtty_ioctl;
extbp_drv.ebtty_ldisc.poll = NULL;
extbp_drv.ebtty_ldisc.receive_buf = ebtty_receive_buf;
extbp_drv.ebtty_ldisc.write_wakeup = NULL; //ebtty_write_wakeup;
if ((status = tty_register_ldisc(extbp_drv.line_disc, &extbp_drv.ebtty_ldisc)) == 0) {
extbp_drv.drv_state |= ST_LDISC_REGISTRATED; }
return status;
}
int ebtty_init (void) {
int status = -1;
if (register_ldisc()) {
err_print(KERN_ERR, DBG_ERROR,
("Can't register line discipline (%d).\n", line_disc));
goto ebtty_init_exit;
}
status = 0;
ebtty_init_exit:
if (status) {
dbg_print(KERN_DEBUG, DBG_ERROR, ("Module initialization failed.\n"));
cleanup();
}
return status;
}
static void cleanup(void) {
int status;
if ((status = tty_unregister_ldisc(extbp_drv.line_disc)) != 0) {
err_print(KERN_ERR, DBG_ERROR,
("Can't unregister line discipline (err = %d)\n", status));
}
}
int init_ebtty_module(void) {
memset(&port_name_path, 0, sizeof(port_name_path));
printk(BSEM_DRV_NAME BP_VER);
sprintf((char *)&port_name_path, "//dev//%s", port_name);
fd=bps_file_open((char *)&port_name_path, 0, O_RDWR);
memset((void*)&extbp_drv, 0, sizeof(struct ext_bypass_drv));
extbp_drv.drv_name = BP_MOD_NAME;
extbp_drv.dev_name = port_name;
extbp_drv.line_disc = line_disc;
extbp_drv.wait_data = LAST_CHAR;
extbp_drv.drv_state = 0;
init_waitqueue_head(&extbp_drv.read_wait);
if (!ebtty_init()) {
extbp_drv.ebtty_major = register_chrdev(0, extbp_drv.drv_name, &ebtty_fops);
if (extbp_drv.ebtty_major < 0) {
err_print(KERN_ERR, DBG_ERROR,
("can't get major %d\n", extbp_drv.ebtty_major));
return extbp_drv.ebtty_major;
}
if (fd != NULL) {
if (!(bps_vfs_ioctl(fd, TIOCSETD, (unsigned long)&line_disc))) {
bps_start_flag = 1;
}
return 0;
}
} else {
if (fd)
filp_close(fd, NULL);
cleanup();
return -1;
}
}
void exit_ebtty_module(void) {
if (fd) {
filp_close(fd, NULL);
fd = 0;
}
cleanup();
}
struct file* filp = NULL;
mm_segment_t oldfs;
oldfs = get_fs();
set_fs(get_ds());
filp = filp_open(path, flags, rights);
set_fs(oldfs);
if (IS_ERR(filp))
return NULL;
return filp;
}
int register_ldisc(void) {
int status;
// Fill in our line protocol discipline, and register it
extbp_drv.ebtty_ldisc.magic = TTY_LDISC_MAGIC;
extbp_drv.ebtty_ldisc.name = BP_LDISC_NAME;
extbp_drv.ebtty_ldisc.flags = 0;
extbp_drv.ebtty_ldisc.open = ebtty_open;
extbp_drv.ebtty_ldisc.close = ebtty_close;
extbp_drv.ebtty_ldisc.read = NULL;
extbp_drv.ebtty_ldisc.write = NULL;
extbp_drv.ebtty_ldisc.ioctl = (int (*)(struct tty_struct *, struct file *,
unsigned int, unsigned long)) ebtty_ioctl;
extbp_drv.ebtty_ldisc.poll = NULL;
extbp_drv.ebtty_ldisc.receive_buf = ebtty_receive_buf;
extbp_drv.ebtty_ldisc.write_wakeup = NULL; //ebtty_write_wakeup;
if ((status = tty_register_ldisc(extbp_drv.line_disc, &extbp_drv.ebtty_ldisc)) == 0) {
extbp_drv.drv_state |= ST_LDISC_REGISTRATED; }
return status;
}
int ebtty_init (void) {
int status = -1;
if (register_ldisc()) {
err_print(KERN_ERR, DBG_ERROR,
("Can't register line discipline (%d).\n", line_disc));
goto ebtty_init_exit;
}
status = 0;
ebtty_init_exit:
if (status) {
dbg_print(KERN_DEBUG, DBG_ERROR, ("Module initialization failed.\n"));
cleanup();
}
return status;
}
static void cleanup(void) {
int status;
if ((status = tty_unregister_ldisc(extbp_drv.line_disc)) != 0) {
err_print(KERN_ERR, DBG_ERROR,
("Can't unregister line discipline (err = %d)\n", status));
}
}
int init_ebtty_module(void) {
memset(&port_name_path, 0, sizeof(port_name_path));
printk(BSEM_DRV_NAME BP_VER);
sprintf((char *)&port_name_path, "//dev//%s", port_name);
fd=bps_file_open((char *)&port_name_path, 0, O_RDWR);
memset((void*)&extbp_drv, 0, sizeof(struct ext_bypass_drv));
extbp_drv.drv_name = BP_MOD_NAME;
extbp_drv.dev_name = port_name;
extbp_drv.line_disc = line_disc;
extbp_drv.wait_data = LAST_CHAR;
extbp_drv.drv_state = 0;
init_waitqueue_head(&extbp_drv.read_wait);
if (!ebtty_init()) {
extbp_drv.ebtty_major = register_chrdev(0, extbp_drv.drv_name, &ebtty_fops);
if (extbp_drv.ebtty_major < 0) {
err_print(KERN_ERR, DBG_ERROR,
("can't get major %d\n", extbp_drv.ebtty_major));
return extbp_drv.ebtty_major;
}
if (fd != NULL) {
if (!(bps_vfs_ioctl(fd, TIOCSETD, (unsigned long)&line_disc))) {
bps_start_flag = 1;
}
return 0;
}
} else {
if (fd)
filp_close(fd, NULL);
cleanup();
return -1;
}
}
void exit_ebtty_module(void) {
if (fd) {
filp_close(fd, NULL);
fd = 0;
}
cleanup();
}
Please advice, maybe I should use something else, instead of line discipline and char device, or maybe I should register and unregister them other way?
0
Categories
- All Categories
- 158 LFX Mentorship
- 158 LFX Mentorship: Linux Kernel
- 847 Linux Foundation IT Professional Programs
- 390 Cloud Engineer IT Professional Program
- 185 Advanced Cloud Engineer IT Professional Program
- 87 DevOps Engineer IT Professional Program
- 154 Cloud Native Developer IT Professional Program
- 152 Express Training Courses & Microlearning
- 149 Express Courses - Discussion Forum
- 3 Microlearning - Discussion Forum
- 7.1K Training Courses
- 50 LFC110 Class Forum - Discontinued
- 74 LFC131 Class Forum
- 56 LFD102 Class Forum
- 253 LFD103 Class Forum
- 26 LFD110 Class Forum
- 50 LFD121 Class Forum
- 3 LFD123 Class Forum
- 1 LFD125 Class Forum
- 19 LFD133 Class Forum
- 10 LFD134 Class Forum
- 19 LFD137 Class Forum
- 1 LFD140 Class Forum
- 73 LFD201 Class Forum
- 8 LFD210 Class Forum
- 6 LFD210-CN Class Forum
- 2 LFD213 Class Forum - Discontinued
- LFD221 Class Forum
- 128 LFD232 Class Forum - Discontinued
- 3 LFD233 Class Forum
- 5 LFD237 Class Forum
- 25 LFD254 Class Forum
- 742 LFD259 Class Forum
- 111 LFD272 Class Forum - Discontinued
- 4 LFD272-JP クラス フォーラム - Discontinued
- 16 LFD273 Class Forum
- 434 LFS101 Class Forum
- 3 LFS111 Class Forum
- 4 LFS112 Class Forum
- 5 LFS116 Class Forum
- 9 LFS118 Class Forum
- 2 LFS120 Class Forum
- 11 LFS142 Class Forum
- 9 LFS144 Class Forum
- 6 LFS145 Class Forum
- 6 LFS146 Class Forum
- 7 LFS147 Class Forum
- 20 LFS148 Class Forum
- 17 LFS151 Class Forum
- 6 LFS157 Class Forum
- 89 LFS158 Class Forum
- 1 LFS158-JP クラス フォーラム
- 14 LFS162 Class Forum
- 2 LFS166 Class Forum - Discontinued
- 9 LFS167 Class Forum
- 4 LFS170 Class Forum
- 2 LFS171 Class Forum - Discontinued
- 4 LFS178 Class Forum - Discontinued
- 4 LFS180 Class Forum
- 3 LFS182 Class Forum
- 7 LFS183 Class Forum
- 2 LFS184 Class Forum
- 41 LFS200 Class Forum
- 737 LFS201 Class Forum - Discontinued
- 3 LFS201-JP クラス フォーラム - Discontinued
- 22 LFS203 Class Forum
- 141 LFS207 Class Forum
- 3 LFS207-DE-Klassenforum
- 3 LFS207-JP クラス フォーラム
- 302 LFS211 Class Forum - Discontinued
- 56 LFS216 Class Forum - Discontinued
- 60 LFS241 Class Forum
- 51 LFS242 Class Forum
- 39 LFS243 Class Forum
- 17 LFS244 Class Forum
- 8 LFS245 Class Forum
- 1 LFS246 Class Forum
- 1 LFS248 Class Forum
- 121 LFS250 Class Forum
- 3 LFS250-JP クラス フォーラム
- 2 LFS251 Class Forum
- 162 LFS253 Class Forum
- 1 LFS254 Class Forum - Discontinued
- 3 LFS255 Class Forum
- 15 LFS256 Class Forum
- 2 LFS257 Class Forum
- 1.4K LFS258 Class Forum
- 12 LFS258-JP クラス フォーラム
- 139 LFS260 Class Forum
- 165 LFS261 Class Forum
- 44 LFS262 Class Forum
- 82 LFS263 Class Forum - Discontinued
- 15 LFS264 Class Forum - Discontinued
- 11 LFS266 Class Forum - Discontinued
- 25 LFS267 Class Forum
- 27 LFS268 Class Forum
- 38 LFS269 Class Forum
- 11 LFS270 Class Forum
- 202 LFS272 Class Forum - Discontinued
- 2 LFS272-JP クラス フォーラム - Discontinued
- 2 LFS274 Class Forum - Discontinued
- 4 LFS281 Class Forum - Discontinued
- 30 LFW111 Class Forum
- 265 LFW211 Class Forum
- 190 LFW212 Class Forum
- 17 SKF100 Class Forum
- 2 SKF200 Class Forum
- 3 SKF201 Class Forum
- 800 Hardware
- 200 Drivers
- 68 I/O Devices
- 37 Monitors
- 104 Multimedia
- 175 Networking
- 92 Printers & Scanners
- 85 Storage
- 765 Linux Distributions
- 82 Debian
- 67 Fedora
- 20 Linux Mint
- 13 Mageia
- 23 openSUSE
- 149 Red Hat Enterprise
- 31 Slackware
- 13 SUSE Enterprise
- 356 Ubuntu
- 472 Linux System Administration
- 39 Cloud Computing
- 71 Command Line/Scripting
- Github systems admin projects
- 96 Linux Security
- 78 Network Management
- 102 System Management
- 48 Web Management
- 74 Mobile Computing
- 19 Android
- 42 Development
- 1.2K New to Linux
- 1K Getting Started with Linux
- 387 Off Topic
- 120 Introductions
- 178 Small Talk
- 28 Study Material
- 833 Programming and Development
- 311 Kernel Development
- 504 Software Development
- 1.8K Software
- 266 Applications
- 183 Command Line
- 5 Compiling/Installing
- 988 Games
- 318 Installation
- 107 All In Program
- 107 All In Forum
Upcoming Training
-
August 20, 2018
Kubernetes Administration (LFS458)
-
August 20, 2018
Linux System Administration (LFS301)
-
August 27, 2018
Open Source Virtualization (LFS462)
-
August 27, 2018
Linux Kernel Debugging and Security (LFD440)