Welcome to the Linux Foundation Forum!

Code is missing proper indentation in "Getting Started with Logging (3)"

Posts: 14
edited March 14 in LFS148 Class Forum

re:

https://trainingportal.linuxfoundation.org/learn/course/getting-started-with-opentelemetry-lfs148/hands-on-lab-manual-instrumentation-logs/hands-on-lab-exercises?page=3

Code reads:

  1. @app.route("/users", methods=["GET"])
  2. def get_user():
  3. user, status = db.get_user(123)
  4. logging.info(f"Found user {user!s} with status {status}")
  5. data = {}
  6. if user is not None:
  7. data = {"id": user.id, "name": user.name, "address": user.address}
  8. else:
  9. logging.warning(f"Could not find user with id {123}")
  10. logging.debug(f"Collected data is {data}")
  11. response = make_response(data, status)
  12. logging.debug(f"Generated response {response}")
  13. return response

Notice if/else missing appropriate indentation. Should probably read:

  1. @app.route("/users", methods=["GET"])
  2. def get_user():
  3. user, status = db.get_user(123)
  4. logging.info(f"Found user {user!s} with status {status}")
  5. data = {}
  6. if user is not None:
  7. data = {"id": user.id, "name": user.name, "address": user.address}
  8. else:
  9. logging.warning(f"Could not find user with id {123}")
  10. logging.debug(f"Collected data is {data}")
  11. response = make_response(data, status)
  12. logging.debug(f"Generated response {response}")
  13. return response

Welcome!

It looks like you're new here. Sign in or register to get started.
Sign In

Welcome!

It looks like you're new here. Sign in or register to get started.
Sign In

Categories

Upcoming Training