Lab 9. Continuous Testing - Integrating E2E Tests with Jenkins

kzwolenik

I've followed the labs and I experience weird results:

When I run it in my terminal it works correctly, new votes count is always one more than current votes count. But when running it in the Jenkins job it says Current Votes Count: 1 and then **New Votes Count: 4

**E2E tests doesn't work and they doesn't fail the Jenkins job

-----------------
Current Votes Count: 1
-----------------

 I: Submitting one more vote...

Not NULL


-----------------
New Votes Count: 4
-----------------

I: Checking if votes tally......

[41m------------
[91mTests failed
[41m------------

...

Finished: SUCCESS

kzwolenik

Looks some delay was needed in the e2e.sh script, manually I was way slower than the script and I couldn't reproduce it

#!/bin/bash 

cd e2e 

docker-compose down > /dev/null 2>&1 

#sleep 10

docker-compose build
docker-compose up -d 

sleep 10

docker-compose ps

docker-compose run --rm e2e

docker-compose down 

But still why the job finished with success even when E2E test failed?

jacqueminv

Hey @kzwolenik that's a good question! The jenkins build should have failed when reaching that branch of the if case:

if [ "$next" -eq "$new" ]; then
  echo -e "\\e[42m------------"
  echo -e "\\e[92mTests passed"
  echo -e "\\e[42m------------"
  exit 0
else
  echo -e "\\e[41m------------"
  echo -e "\\e[91mTests failed"
  echo -e "\\e[41m------------"
  exit 1
fi

I'd assume that when the script returns exit 1 the job would fail too.
Were you able to reproduce since you fixed the other issue?