Welcome to the Linux Foundation Forum!
Mistake: Lab 5.2 - Prototypal Inheritance
dmsheiko
Posts: 16
Hi,
There are some mistakes in code that verifies the prototype chain.
Here is the code:
assert(Object.getOwnPropertyNames(felixProto).length, 1) assert(Object.getOwnPropertyNames(felixProtoProto).length, 1) assert(Object.getOwnPropertyNames(felixProtoProto).length, 1) assert(typeof felixProto.meow, 'function') assert(typeof felixProtoProto.purr, 'function') assert(typeof felixProtoProtoProto.hiss, 'function')
- the 3rd line should likely check felixProtoProtoProto rather than felixProtoProto (which is already checked in previous line)
- there should be assert.equal rather than assert.
- in case of class syntax, Object.getOwnPropertyNames() may return 'constructor' in addition to 'meow', 'purr' or 'hiss', and I believe this is acceptable. So instead of checking the number of property names I would check the content of the array.
So, I would rewrite the checks this way:
// prototype checks, do not remove const felixProto = Object.getPrototypeOf(felix) const felixProtoProto = Object.getPrototypeOf(felixProto) const felixProtoProtoProto = Object.getPrototypeOf(felixProtoProto) function checkOwnPropertyNames(proto, right, ...wrongs) { const ownPropertyNames = Object.getOwnPropertyNames(proto) assert(ownPropertyNames.includes(right), `${ownPropertyNames} should contain ${right}`) for (const wrong of wrongs) { assert(!ownPropertyNames.includes(wrong), `${ownPropertyNames} should NOT contain ${wrong}`) } } checkOwnPropertyNames(felixProto, 'meow', 'purr', 'hiss') checkOwnPropertyNames(felixProtoProto, 'purr', 'hiss', 'meow') checkOwnPropertyNames(felixProtoProtoProto, 'hiss', 'meow', 'purr') assert.equal(typeof felixProto.meow, 'function') assert.equal(typeof felixProtoProto.purr, 'function') assert.equal(typeof felixProtoProtoProto.hiss, 'function') console.log('prototype checks passed!')
Regards,
Dmytro
249ymzn0nkk5-LFW211Labs06.28.2023.pdf
h08po53bto1k-labs-june-2023.zip
1
Comments
-
thanks @dmsheiko great catches and feedback, this being fixed, I went with:
const assert = require('assert') // TODO: // implement a way to create a prototype chain // of leopard -> lynx -> cat // leopard prototype must have ONLY a hiss method // lynx prototype must have ONLY a purr method // cat prototype must have ONLY a meow method const felix = null //TODO replace null with instantiation of a cat felix.meow() // prints Felix the cat: meow felix.purr() // prints Felix the cat: prrr felix.hiss() // prints Felix the cat: hsss // prototype checks, do not remove const felixProto = Object.getPrototypeOf(felix) const felixProtoProto = Object.getPrototypeOf(felixProto) const felixProtoProtoProto = Object.getPrototypeOf(felixProtoProto) const protoPropNames = Object.getOwnPropertyNames(felixProto) const protoProtoPropNames = Object.getOwnPropertyNames(felixProtoProto) const protoProtoProtoPropNames = Object.getOwnPropertyNames(felixProtoProtoProto) assert(protoPropNames.includes('meow')) assert(protoProtoPropNames.includes('purr')) assert(protoProtoProtoPropNames.includes('hiss')) assert(protoPropNames.length <= (protoPropNames.includes('constructor') ? 2 : 1)) assert(protoProtoPropNames.length <= (protoProtoPropNames.includes('constructor') ? 2 : 1)) assert(protoProtoProtoPropNames.length <= (protoProtoProtoPropNames.includes('constructor') ? 2 : 1)) assert.equal(typeof felixProto.meow, 'function') assert.equal(typeof felixProtoProto.purr, 'function') assert.equal(typeof felixProtoProtoProto.hiss, 'function') console.log('prototype checks passed!')
This way failure information is most rich (i.e. first you know if you haven't put a method in a correct place, then you know if there are too many properties anywhere (allowing for constructor), then you know if you've not made it a method. I also prefer flatness and minimum indirection for these scripts. Thanks again!
1
Categories
- All Categories
- 208 LFX Mentorship
- 208 LFX Mentorship: Linux Kernel
- 738 Linux Foundation IT Professional Programs
- 340 Cloud Engineer IT Professional Program
- 167 Advanced Cloud Engineer IT Professional Program
- 67 DevOps Engineer IT Professional Program
- 133 Cloud Native Developer IT Professional Program
- 123 Express Training Courses
- 123 Express Courses - Discussion Forum
- 6K Training Courses
- 40 LFC110 Class Forum - Discontinued
- 67 LFC131 Class Forum
- 40 LFD102 Class Forum
- 223 LFD103 Class Forum
- 18 LFD110 Class Forum
- 35 LFD121 Class Forum
- 18 LFD133 Class Forum
- 7 LFD134 Class Forum
- 18 LFD137 Class Forum
- 71 LFD201 Class Forum
- 4 LFD210 Class Forum
- 3 LFD210-CN Class Forum
- 2 LFD213 Class Forum - Discontinued
- 128 LFD232 Class Forum - Discontinued
- 2 LFD233 Class Forum
- 4 LFD237 Class Forum
- 24 LFD254 Class Forum
- 691 LFD259 Class Forum
- 111 LFD272 Class Forum
- 4 LFD272-JP クラス フォーラム
- 11 LFD273 Class Forum
- 119 LFS101 Class Forum
- 1 LFS111 Class Forum
- 3 LFS112 Class Forum
- 2 LFS116 Class Forum
- 4 LFS118 Class Forum
- 4 LFS142 Class Forum
- 5 LFS144 Class Forum
- 4 LFS145 Class Forum
- 2 LFS146 Class Forum
- 3 LFS147 Class Forum
- 9 LFS151 Class Forum
- 2 LFS157 Class Forum
- 19 LFS158 Class Forum
- 6 LFS162 Class Forum
- 2 LFS166 Class Forum
- 4 LFS167 Class Forum
- 2 LFS170 Class Forum
- 2 LFS171 Class Forum
- 3 LFS178 Class Forum
- 3 LFS180 Class Forum
- 2 LFS182 Class Forum
- 5 LFS183 Class Forum
- 31 LFS200 Class Forum
- 737 LFS201 Class Forum - Discontinued
- 3 LFS201-JP クラス フォーラム
- 18 LFS203 Class Forum
- 120 LFS207 Class Forum
- 2 LFS207-DE-Klassenforum
- 1 LFS207-JP クラス フォーラム
- 302 LFS211 Class Forum
- 56 LFS216 Class Forum
- 51 LFS241 Class Forum
- 46 LFS242 Class Forum
- 38 LFS243 Class Forum
- 14 LFS244 Class Forum
- 2 LFS245 Class Forum
- 46 LFS250 Class Forum
- 2 LFS250-JP クラス フォーラム
- 1 LFS251 Class Forum
- 148 LFS253 Class Forum
- 1 LFS254 Class Forum
- 1 LFS255 Class Forum
- 7 LFS256 Class Forum
- 1 LFS257 Class Forum
- 1.2K LFS258 Class Forum
- 10 LFS258-JP クラス フォーラム
- 117 LFS260 Class Forum
- 158 LFS261 Class Forum
- 42 LFS262 Class Forum
- 82 LFS263 Class Forum - Discontinued
- 15 LFS264 Class Forum - Discontinued
- 11 LFS266 Class Forum - Discontinued
- 24 LFS267 Class Forum
- 19 LFS268 Class Forum
- 30 LFS269 Class Forum
- 201 LFS272 Class Forum
- 2 LFS272-JP クラス フォーラム
- 1 LFS274 Class Forum
- 4 LFS281 Class Forum
- 9 LFW111 Class Forum
- 258 LFW211 Class Forum
- 181 LFW212 Class Forum
- 13 SKF100 Class Forum
- 1 SKF200 Class Forum
- 1 SKF201 Class Forum
- 791 Hardware
- 199 Drivers
- 68 I/O Devices
- 37 Monitors
- 98 Multimedia
- 174 Networking
- 91 Printers & Scanners
- 85 Storage
- 755 Linux Distributions
- 82 Debian
- 67 Fedora
- 16 Linux Mint
- 13 Mageia
- 23 openSUSE
- 147 Red Hat Enterprise
- 31 Slackware
- 13 SUSE Enterprise
- 352 Ubuntu
- 465 Linux System Administration
- 39 Cloud Computing
- 71 Command Line/Scripting
- Github systems admin projects
- 91 Linux Security
- 78 Network Management
- 101 System Management
- 47 Web Management
- 56 Mobile Computing
- 17 Android
- 28 Development
- 1.2K New to Linux
- 1K Getting Started with Linux
- 366 Off Topic
- 114 Introductions
- 171 Small Talk
- 20 Study Material
- 534 Programming and Development
- 293 Kernel Development
- 223 Software Development
- 1.2K Software
- 212 Applications
- 182 Command Line
- 3 Compiling/Installing
- 405 Games
- 312 Installation
- 79 All In Program
- 79 All In Forum
Upcoming Training
-
August 20, 2018
Kubernetes Administration (LFS458)
-
August 20, 2018
Linux System Administration (LFS301)
-
August 27, 2018
Open Source Virtualization (LFS462)
-
August 27, 2018
Linux Kernel Debugging and Security (LFD440)