How to defer device driver initialization?
Hello everyone
I've stuck in a problem of deferring initialization of a driver.
I need to initialize LCD panel driver after PMIC driver is done. But somehow kernel make them initialize vice versa. So, that's why I have to make special things in a driver code.
I made steps in two files:
dts:
/ { display-dsi { compatible = "simple-bus"; #interrupt-cells = <1>; #address-cells = <1>; #size-cells = <1>; ranges = <>; lcd_eldo: reg_eldo1 { compatible = "regulator-fixed"; regulator-name = "lcd_eldo"; regulator-always-on; regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; }; panel_ili9881@0 { compatible = "ingenic,ili9881"; power-supply = <&lcd_eldo>; ingenic,bl-gpio = <&gpd 2 GPIO_ACTIVE_HIGH INGENIC_GPIO_NOBIAS>; ingenic,rst-gpio = <&gpc 6 GPIO_ACTIVE_HIGH INGENIC_GPIO_NOBIAS>; ingenic,lcd_pwm-gpio = <&gpb 7 GPIO_ACTIVE_HIGH INGENIC_GPIO_NOBIAS>; status = "okay"; }; }; };
driver code:
static int panel_probe(struct platform_device *pdev) { panel = kzalloc(sizeof(struct panel_dev), GFP_KERNEL); if (IS_ERR_OR_NULL(panel)) { dev_err(&pdev->dev, "Failed to alloc memory!\n"); return -ENOMEM; } panel->dev = &pdev->dev; dev_set_drvdata(&pdev->dev, panel); ret = of_panel_parse(&pdev->dev); if (ret < 0) { printk("panel probe: err_of_parse\n"); goto err_of_parse; } struct regulator * pvcc; pvcc = devm_regulator_get(&pdev->dev, "lcd_eldo"); if (IS_ERR(pvcc)) { printk("---##&##--- lcd_eldo LCD: FAIL\n"); return -EPROBE_DEFER; } /* ... */ }
I expected the project work normally, but a system log shows following:
display-dsi:panel_ili9881@0 supply lcd_eldo not found, using dummy regulator
As far as I understand it means:
- devm_regulator_get() can not find regulator name
- system should have returned an error, but it activates the dummy_regulator instead
Any ideas?
Best Answer
-
I've found a solution I guess
I should have used a devm_regulator_get_exclusive() function, because it does not activates dummy_regulator and returns an error instead. Then it becomes possible to operate the returning value to defer the driver initialization.The function body:
struct regulator *devm_regulator_get_exclusive(struct device *dev, char *id) { return _devm_regulator_get(dev, id, EXCLUSIVE_GET); }
Then in the function the system goes to case EXCLUSIVE_GET
static struct regulator *_devm_regulator_get(struct device *dev, const char *id, get_type) { struct regulator **ptr, *regulator; ptr = devres_alloc(devm_regulator_release, sizeof(*ptr), GFP_KERNEL); if (!ptr) return ERR_PTR(-ENOMEM); switch (get_type) { case NORMAL_GET: regulator = regulator_get(dev, id); break; case EXCLUSIVE_GET: regulator = regulator_get_exclusive(dev, id); break; case OPTIONAL_GET: regulator = regulator_get_optional(dev, id); break; default: regulator = ERR_PTR(-EINVAL); } if (!IS_ERR(regulator)) { *ptr = regulator; devres_add(dev, ptr); } else devres_free(ptr); return regulator; }
Then
struct regulator *regulator_get_exclusive(struct device *dev, const char *id) { return _regulator_get(dev, id, true, false); } /* _regulator_get heading */ static struct regulator *_regulator_get ( struct device *dev, const char *id, bool exclusive, bool allow_dummy ) /* * allow_dummy = false */
That means the devm_regulator_get_exclusive() function returns what I need
struct regulator * pvcc; pvcc = devm_regulator_get_exclusive(&pdev->dev, "lcd_eldo"); if (IS_ERR(pvcc)) { printk("---##&##--- lcd_eldo LCD: FAIL\n"); return -EPROBE_DEFER; } /* ... */
It works normally:
- accroding to the error code of devm_regulator_get_exclusive() I can return EPROBE_DEFER in driver probe function
- if there is no error code, it's possible to make my driver initialize
0
Answers
-
@vanovsky777 said:
I've found a solution I guess
I should have used a devm_regulator_get_exclusive() function, because it does not activates dummy_regulator and returns an error instead. Then it becomes possible to operate the returning value to defer the driver initialization.The function body:
struct regulator *devm_regulator_get_exclusive(struct device *dev, char *id) { return _devm_regulator_get(dev, id, EXCLUSIVE_GET); }
Then in the function the system goes to case EXCLUSIVE_GET
static struct regulator *_devm_regulator_get(struct device *dev, const char *id, get_type) { struct regulator **ptr, *regulator; ptr = devres_alloc(devm_regulator_release, sizeof(*ptr), GFP_KERNEL); if (!ptr) return ERR_PTR(-ENOMEM); switch (get_type) { case NORMAL_GET: regulator = regulator_get(dev, id); break; case EXCLUSIVE_GET: regulator = regulator_get_exclusive(dev, id); break; case OPTIONAL_GET: regulator = regulator_get_optional(dev, id); break; default: regulator = ERR_PTR(-EINVAL); } if (!IS_ERR(regulator)) { *ptr = regulator; devres_add(dev, ptr); } else devres_free(ptr); return regulator; }
Then
struct regulator *regulator_get_exclusive(struct device *dev, const char *id) { return _regulator_get(dev, it, true, false); } /* _regulator_get heading */ static struct regulator *_regulator_get ( struct device *dev, const char *id, bool exclusive, bool allow_dummy ) /* * allow_dummy = false */
That means the devm_regulator_get_exclusive() function returns what I need
struct regulator * pvcc; pvcc = devm_regulator_get_exclusive(&pdev->dev, "lcd_eldo"); if (IS_ERR(pvcc)) { printk("---##&##--- lcd_eldo LCD: FAIL\n"); return -EPROBE_DEFER; } /* ... */
It works normally:
- accroding to the error code of devm_regulator_get_exclusive() I can return EPROBE_DEFER in driver probe function
- if there is no error code, it's possible to make my driver initialize
Exactly, this is the best answer to the problem "How to defer device driver initialization?. Thanks to vanovsky777
vanovsky777.0
Categories
- All Categories
- 112 LFX Mentorship
- 112 LFX Mentorship: Linux Kernel
- 604 Linux Foundation IT Professional Programs
- 315 Cloud Engineer IT Professional Program
- 139 Advanced Cloud Engineer IT Professional Program
- 52 DevOps Engineer IT Professional Program
- 67 Cloud Native Developer IT Professional Program
- 3 Express Training Courses
- 3 Express Courses - Discussion Forum
- 5.3K Training Courses
- 17 LFC110 Class Forum - Discontinued
- 8 LFC131 Class Forum
- 30 LFD102 Class Forum
- 178 LFD103 Class Forum
- LFD110 Class Forum
- 24 LFD121 Class Forum
- LFD133 Class Forum
- 2 LFD137 Class Forum
- 62 LFD201 Class Forum
- 2 LFD210 Class Forum
- 1 LFD210-CN Class Forum
- 1 LFD213 Class Forum - Discontinued
- 127 LFD232 Class Forum - Discontinued
- LFD233 Class Forum
- LFD237 Class Forum
- 22 LFD254 Class Forum
- 643 LFD259 Class Forum
- 107 LFD272 Class Forum
- 1 LFD272-JP クラス フォーラム
- 4 LFD273 Class Forum
- 1 LFS101 Class Forum
- LFS112 Class Forum
- LFS116 Class Forum
- LFS118 Class Forum
- LFS142 Class Forum
- LFS144 Class Forum
- 2 LFS145 Class Forum
- LFS146 Class Forum
- LFS151 Class Forum
- LFS157 Class Forum
- LFS158 Class Forum
- LFS162 Class Forum
- LFS167 Class Forum
- 28 LFS200 Class Forum
- 735 LFS201 Class Forum - Discontinued
- 1 LFS201-JP クラス フォーラム
- 13 LFS203 Class Forum
- 98 LFS207 Class Forum
- 299 LFS211 Class Forum
- 54 LFS216 Class Forum
- 47 LFS241 Class Forum
- 41 LFS242 Class Forum
- 36 LFS243 Class Forum
- 12 LFS244 Class Forum
- LFS245 Class Forum
- 41 LFS250 Class Forum
- 1 LFS250-JP クラス フォーラム
- LFS251 Class Forum
- 141 LFS253 Class Forum
- LFS254 Class Forum
- LFS255 Class Forum
- 2 LFS256 Class Forum
- LFS257 Class Forum
- 1.2K LFS258 Class Forum
- 9 LFS258-JP クラス フォーラム
- 109 LFS260 Class Forum
- 144 LFS261 Class Forum
- 39 LFS262 Class Forum
- 82 LFS263 Class Forum - Discontinued
- 15 LFS264 Class Forum - Discontinued
- 11 LFS266 Class Forum - Discontinued
- 20 LFS267 Class Forum
- 18 LFS268 Class Forum
- 26 LFS269 Class Forum
- 198 LFS272 Class Forum
- 1 LFS272-JP クラス フォーラム
- LFS274 Class Forum
- 3 LFS281 Class Forum
- 254 LFW211 Class Forum
- 173 LFW212 Class Forum
- 9 SKF100 Class Forum
- SKF200 Class Forum
- 781 Hardware
- 198 Drivers
- 68 I/O Devices
- 37 Monitors
- 95 Multimedia
- 174 Networking
- 87 Printers & Scanners
- 83 Storage
- 742 Linux Distributions
- 80 Debian
- 66 Fedora
- 15 Linux Mint
- 13 Mageia
- 23 openSUSE
- 143 Red Hat Enterprise
- 31 Slackware
- 13 SUSE Enterprise
- 347 Ubuntu
- 450 Linux System Administration
- 31 Cloud Computing
- 69 Command Line/Scripting
- Github systems admin projects
- 89 Linux Security
- 76 Network Management
- 101 System Management
- 46 Web Management
- 51 Mobile Computing
- 18 Android
- 23 Development
- 1.2K New to Linux
- 1K Getting Started with Linux
- 355 Off Topic
- 109 Introductions
- 167 Small Talk
- 18 Study Material
- 504 Programming and Development
- 283 Kernel Development
- 203 Software Development
- 844 Software
- 210 Applications
- 180 Command Line
- 3 Compiling/Installing
- 107 Games
- 308 Installation
- 51 All In Program
- 51 All In Forum
Upcoming Training
-
August 20, 2018
Kubernetes Administration (LFS458)
-
August 20, 2018
Linux System Administration (LFS301)
-
August 27, 2018
Open Source Virtualization (LFS462)
-
August 27, 2018
Linux Kernel Debugging and Security (LFD440)