Lab 4.2 - Stream some content

Hi,
In lab 4.2, I'm trying this:
The reply.send method can also be passed a stream and Fastify behaves in the same >way - by piping the stream as the HTTP response."
but I don't get it
const dataStream = require('./../../stream'); module.exports = async function (fastify, opts) { fastify.get('/', async function (request, reply) { reply.send(dataStream); }) }
I have also tried with this
const dataStream = require('./../../stream'); module.exports = async function (fastify, opts) { fastify.get('/', async function (request, reply) { reply.header('Content-Type', 'application/octet-stream'); reply.send(dataStream); }) }
Anyone can help me?
Thanks in advance.
Comments
-
Hi,
I have found the answer
'use strict' const stream = require('./../../stream'); module.exports = async function (fastify, opts) { fastify.get('/', async function (request, reply) { reply.headers({'content-type': 'text/html' }); await reply.send(stream()); }) }
but I don't understand totally why this is working.
Why I have to await for reply?
Thanks
0 -
it's not about the await - you were passing a function, now you're passing a stream. Note that you're CALLING
stream()
in your working example1 -
Hi @xdxmxc,
Without await it doesn't work
'use strict' const stream = require('./../../stream'); module.exports = async function (fastify, opts) { fastify.get('/', async function (request, reply) { reply.headers({'content-type': 'text/html' }); reply.send(stream()); }) }
0 -
Hi, @arturo.miguel.next ,
You can remove both
await
andasync
for the route handler.Like this:
'use strict' const stream = require('./../../stream'); module.exports = async function (fastify, opts) { fastify.get('/', function (request, reply) { reply.type('text/html'); reply.send(stream()); }) }
The reason why your async version handler doesn't work without
await
maybe the internal mechanism of fastify I guess.According to your code, here is an equivalent code with implicit
return
:'use strict' const stream = require('./../../stream'); module.exports = async function (fastify, opts) { fastify.get('/', async function (request, reply) { reply.headers({'content-type': 'text/html' }); reply.send(stream()); return; // this is an implicit }) }
The implicit
return
notifies fastify that this async function is already over. Fastify does not necessarily need to wait anything else to finish the response. The possible hypothesis might be "Hey, it is already an async handler. If there is anything I need to wait, why would it already returned. It totally could wait inside the function and return lately".When you add the await before
reply.send(stream())
, the handler will waitreply.send(stream())
to finish before return the function. Then end the HTTP response.You can verify by this:
'use strict' const stream = require("../../stream") module.exports = async function (fastify, opts) { fastify.get('/', async function (request, reply) { reply.type('text/html'); reply.send(stream()); return "Hi, I am Krave." }) }
You will see that the response to client finishes immediately without any delay.
1 -
yes @krave is exactly right. Regarding the await, when the route handler returns a promise (as all async functions do) the resolution of the promise determines when the route has been completely handled - not the stream passed to reply send, however the promise returned from reply.send can be awaited in this case to ensure the promise resolves after the stream completes. While this seems clunky it's merely supporting an edge-case, it's better not to mix reply.send and async route functions. So in practice you can either go the way @krave shows OR you avoid reply.send and instead return the stream (or whatever value) from the function (should work async or not).
1
Categories
- 9.9K All Categories
- 29 LFX Mentorship
- 82 LFX Mentorship: Linux Kernel
- 469 Linux Foundation Boot Camps
- 267 Cloud Engineer Boot Camp
- 95 Advanced Cloud Engineer Boot Camp
- 43 DevOps Engineer Boot Camp
- 31 Cloud Native Developer Boot Camp
- 1 Express Training Courses
- 1 Express Courses - Discussion Forum
- 1.6K Training Courses
- 18 LFC110 Class Forum
- 4 LFC131 Class Forum
- 19 LFD102 Class Forum
- 133 LFD103 Class Forum
- 9 LFD121 Class Forum
- 60 LFD201 Class Forum
- LFD210 Class Forum
- 1 LFD213 Class Forum - Discontinued
- 128 LFD232 Class Forum
- 23 LFD254 Class Forum
- 545 LFD259 Class Forum
- 100 LFD272 Class Forum
- 1 LFD272-JP クラス フォーラム
- 1 LFS145 Class Forum
- 20 LFS200 Class Forum
- 739 LFS201 Class Forum
- 1 LFS201-JP クラス フォーラム
- 1 LFS203 Class Forum
- 37 LFS207 Class Forum
- 296 LFS211 Class Forum
- 53 LFS216 Class Forum
- 45 LFS241 Class Forum
- 40 LFS242 Class Forum
- 33 LFS243 Class Forum
- 10 LFS244 Class Forum
- 27 LFS250 Class Forum
- 1 LFS250-JP クラス フォーラム
- 131 LFS253 Class Forum
- 967 LFS258 Class Forum
- 10 LFS258-JP クラス フォーラム
- 85 LFS260 Class Forum
- 124 LFS261 Class Forum
- 29 LFS262 Class Forum
- 78 LFS263 Class Forum
- 15 LFS264 Class Forum
- 10 LFS266 Class Forum
- 17 LFS267 Class Forum
- 16 LFS268 Class Forum
- 14 LFS269 Class Forum
- 194 LFS272 Class Forum
- 1 LFS272-JP クラス フォーラム
- 207 LFW211 Class Forum
- 148 LFW212 Class Forum
- 892 Hardware
- 213 Drivers
- 74 I/O Devices
- 44 Monitors
- 115 Multimedia
- 206 Networking
- 100 Printers & Scanners
- 85 Storage
- 747 Linux Distributions
- 88 Debian
- 64 Fedora
- 13 Linux Mint
- 13 Mageia
- 24 openSUSE
- 133 Red Hat Enterprise
- 33 Slackware
- 13 SUSE Enterprise
- 354 Ubuntu
- 469 Linux System Administration
- 38 Cloud Computing
- 68 Command Line/Scripting
- Github systems admin projects
- 93 Linux Security
- 77 Network Management
- 107 System Management
- 48 Web Management
- 62 Mobile Computing
- 22 Android
- 26 Development
- 1.2K New to Linux
- 1.1K Getting Started with Linux
- 524 Off Topic
- 127 Introductions
- 210 Small Talk
- 19 Study Material
- 783 Programming and Development
- 257 Kernel Development
- 492 Software Development
- 919 Software
- 255 Applications
- 181 Command Line
- 2 Compiling/Installing
- 76 Games
- 316 Installation
- 46 All In Program
- 46 All In Forum
Upcoming Training
-
August 20, 2018
Kubernetes Administration (LFS458)
-
August 20, 2018
Linux System Administration (LFS301)
-
August 27, 2018
Open Source Virtualization (LFS462)
-
August 27, 2018
Linux Kernel Debugging and Security (LFD440)