Validation rule of ch-4 labs-1

Hi, I have noticed that the 2nd criteria of the validation - reuses the layout.hbs view to render
validating HTML code via regexp.
And based on the regexp, it assumes that the last CSS rule in one CSS block should not be suffixed with semicolon.
Although the semicolon of last rule is not necessary, I was taught that it would be a good habit to reserve it instead of removing it. This is a good habit because e.g. you do not need to care about the semicolon if you want to change the order of the rules, you can also freely to append new rules without adding semicolon. So as to git diff, you will not see many history recods about the semicolon alone and leaving the import part highlightened.
So I always keep the semicolon of the last rule in CSS block. Which in turn prevents me from passing the validation.
Is it possible to make some adjustments? For example, we can use ;?
to remove the constraint of 'must remove the semicolon of last rule in CSS blocks' ?
Thank you for your time in advance.
Comments
-
@krave this is a good point, if you'd like you can modify the regexp and post it here with your example input and I'll work on updating the validation code for that question
0 -
@davidmarkclements
Here is the updated regexpRegExp
const markers = RegExp('<style>\\s+body\\s+{\\s+background:\\s+#333;\\s+margin:\\s+1\\.25rem;?\\s+}' + '\\s+h1\\s+{\\s+color:\\s+#EEE;\\s+font-family:\\s+sans-serif;?\\s+}\\s+a\\s+{\\s+' + 'color:\\s+yellow;\\s+font-size:\\s+2rem;\\s+font-family:\\s+sans-serif;?\\s+}\\s+' + '<\\/style>')
Since the style sheet is originated from
views/layout.hbs
, I post two version of the file here as input examples.layout.hbs - all rules with semicolon
<html> <head> <style> body { background: #333; margin: 1.25rem; } h1 { color: #EEE; font-family: sans-serif; } a { color: yellow; font-size: 2rem; font-family: sans-serif; } </style> </head> <body> {{{ body }}} </body> </html>
layout.hbs - last rule without semicolon
<html> <head> <style> body { background: #333; margin: 1.25rem } h1 { color: #EEE; font-family: sans-serif } a { color: yellow; font-size: 2rem; font-family: sans-serif } </style> </head> <body> {{{ body }}} </body> </html>
I have tested the RegExp on both cases and both passed. Hope that helps.
0
Categories
- All Categories
- 51 LFX Mentorship
- 104 LFX Mentorship: Linux Kernel
- 576 Linux Foundation IT Professional Programs
- 304 Cloud Engineer IT Professional Program
- 125 Advanced Cloud Engineer IT Professional Program
- 53 DevOps Engineer IT Professional Program
- 61 Cloud Native Developer IT Professional Program
- 5 Express Training Courses
- 5 Express Courses - Discussion Forum
- 2K Training Courses
- 19 LFC110 Class Forum
- 7 LFC131 Class Forum
- 27 LFD102 Class Forum
- 157 LFD103 Class Forum
- 20 LFD121 Class Forum
- 1 LFD137 Class Forum
- 61 LFD201 Class Forum
- 1 LFD210 Class Forum
- LFD210-CN Class Forum
- 1 LFD213 Class Forum - Discontinued
- 128 LFD232 Class Forum
- LFD237 Class Forum
- 23 LFD254 Class Forum
- 611 LFD259 Class Forum
- 105 LFD272 Class Forum
- 1 LFD272-JP クラス フォーラム
- 1 LFD273 Class Forum
- 2 LFS145 Class Forum
- 24 LFS200 Class Forum
- 739 LFS201 Class Forum
- 1 LFS201-JP クラス フォーラム
- 11 LFS203 Class Forum
- 75 LFS207 Class Forum
- 300 LFS211 Class Forum
- 54 LFS216 Class Forum
- 47 LFS241 Class Forum
- 41 LFS242 Class Forum
- 37 LFS243 Class Forum
- 11 LFS244 Class Forum
- 36 LFS250 Class Forum
- 1 LFS250-JP クラス フォーラム
- LFS251 Class Forum
- 140 LFS253 Class Forum
- LFS254 Class Forum
- 1.1K LFS258 Class Forum
- 10 LFS258-JP クラス フォーラム
- 93 LFS260 Class Forum
- 132 LFS261 Class Forum
- 33 LFS262 Class Forum
- 80 LFS263 Class Forum
- 15 LFS264 Class Forum
- 11 LFS266 Class Forum
- 18 LFS267 Class Forum
- 17 LFS268 Class Forum
- 23 LFS269 Class Forum
- 203 LFS272 Class Forum
- 1 LFS272-JP クラス フォーラム
- LFS274 Class Forum
- LFS281 Class Forum
- 235 LFW211 Class Forum
- 172 LFW212 Class Forum
- 7 SKF100 Class Forum
- SKF200 Class Forum
- 902 Hardware
- 219 Drivers
- 74 I/O Devices
- 44 Monitors
- 115 Multimedia
- 209 Networking
- 101 Printers & Scanners
- 85 Storage
- 763 Linux Distributions
- 88 Debian
- 66 Fedora
- 15 Linux Mint
- 13 Mageia
- 24 openSUSE
- 142 Red Hat Enterprise
- 33 Slackware
- 13 SUSE Enterprise
- 357 Ubuntu
- 479 Linux System Administration
- 41 Cloud Computing
- 70 Command Line/Scripting
- Github systems admin projects
- 95 Linux Security
- 78 Network Management
- 108 System Management
- 49 Web Management
- 68 Mobile Computing
- 23 Android
- 30 Development
- 1.2K New to Linux
- 1.1K Getting Started with Linux
- 537 Off Topic
- 131 Introductions
- 217 Small Talk
- 21 Study Material
- 826 Programming and Development
- 278 Kernel Development
- 514 Software Development
- 928 Software
- 260 Applications
- 184 Command Line
- 3 Compiling/Installing
- 76 Games
- 316 Installation
- 63 All In Program
- 63 All In Forum
Upcoming Training
-
August 20, 2018
Kubernetes Administration (LFS458)
-
August 20, 2018
Linux System Administration (LFS301)
-
August 27, 2018
Open Source Virtualization (LFS462)
-
August 27, 2018
Linux Kernel Debugging and Security (LFD440)