Welcome to the Linux Foundation Forum!

Lab 6.2: Unable to pass the test - fastify should be greater than or equal to 2.0.0, while accepting

shahahmed
shahahmed Posts: 1
edited May 9 in LFW211 Class Forum

I have tried several different ways to install fastify on the project. And I know for the fact that the installation was correct but there something seems to be off with the test if I am not wrong.

I tried installations the following way,

npm install --save --save-exact [email protected]

Resulting in the following entry in package.json,

"fastify": "2.15.3"

But the test fails here.

Then I tried the following, hoping that should resolve the test,

npm install --save --save-exact [email protected]

But the test fails here too. Not sure what is going on here but atleast one of the two above mentioned should pass the test.

Test from the downloaded assignments/labs,

'use strict'

const assert = require('assert')
const semver = require('semver')
const pkg = require('./package.json')
assert.doesNotThrow(() => {
  require('fastify')
}, 'fastify should be installed')
assert.doesNotThrow(() => {
  require('rfdc')
}, 'rfdc should be installed')
const { dependencies = {} } = pkg
const deplist = Object.entries(dependencies)
const fastify = deplist.find(([name]) => name === 'fastify').pop()
const rfdc = deplist.find(([name]) => name === 'rfdc').pop()
assert(rfdc === '1.1.3', 'rfdc should be at exactly 1.1.3')
const { range } = new semver.Range(fastify)
console.log(range)
assert(range === '>=2.0.0 <3.0.0-0', 'fastify should be greater than or equal to 2.0.0, while accepting all future MINOR and PATCH versions')
console.log('passed')

Can anyone please point out what is going wrong here?

Thanks.

Comments

  • danieltkach
    danieltkach Posts: 2

    I have the same issue, I believe I'm doing it correctly. What's your package.json, mine is:
    {
    "name": "labs-2",
    "version": "1.0.0",
    "description": "",
    "main": "index.js",
    "scripts": {
    "test": "node test"
    },
    "keywords": [],
    "author": "",
    "license": "ISC",
    "dependencies": {
    "fastify": "^2.15.3",
    "rfdc": "1.1.3",
    "semver": "^7.3.4"
    }
    }

  • kellv
    kellv Posts: 14

    @shahahmed, your comment makes sense to me, and I even validated over at: https://semver.npmjs.com/ using their fastify example. I think this example is looking for their way. I would love to know if the graders take into account this example...

  • I need to check this again, last time it was a breaking change in a minor version of semver (which is ironic), it may be that this has happened again in the opposite direction. @kellv I'm also going to check the grading on this one as well

Categories

Upcoming Training