ch-7/labs-1

ronniery

Hello everyone, I'm trying to make a code to pass in the labs-1 from chapter 7, but in the given code from the package, we have something like that:

Ok if we assume somehtings like that:
var brands = [ 'Boston Whaler','Chaparral','Grady-White','Lund','MasterCraft','Sea Ray' ] ( length = 6 ), when id is equal to 1 the output of the given code will be undefined because the 1 - 231 evaluates to a number that is less than 0 and the modulus of (-230 % brands.length) is -2, when node evaluates brands[-2] it awlays returns an undefined value.

Does this code is correct or am I missed something?

theodoros

yes, i think you are right.
i abandoned that excersice because, it seems that the 'validation' is not correct @davidmarkclements.

validation fails on :
GET http://localhost:3000/1 must respond with correct data
got - {"id":1,"color":"Red"})

But the id:1, it will never give correct data, on the brand service, because :
node -p "(1-231)%6"
-2

Is it something more than that ?
Any help appreciated.

theodoros

Ah, ok @ronniery , there is no problem with the code.
The answer is on that post: https://forum.linuxfoundation.org/discussion/857850/lab-7-1-incorrect-part-in-the-text-of-the-exercise#latest

We should make a request to the '/boat' service and then use the 'boat.brand' to make a request to the '/brand' service.

all good!

davidmarkclements

yes @theodoros is correct, the code is trying to simulate a scenario for the situation you've described