HELP... error in my simple binary search program
Could any help me with a runtime error in my program?
In the program of binary search, I am not getting output if I choose my searching element more than the middle element.
Could anyone please help me to debug it?
#include
using namespace std;
int main()
{
int a[100],n,ele,mid,pos=0;
cout<<"\nEnter the number of elements you want to enter in an array: ";<br />
cin>>n;
cout<<"\nEnter the array: ";<br />
for(int i=0;i
cin>>a[i];
cout<<"\nEnter the element you want to search: ";<br />
cin>>ele;
int low=0,high=n-1;
while(low<=high)<br />
{
mid=low+high/2;
if(ele==a[mid])
{
pos=mid+1;
break;
}
else if(ele
high=mid-1;
else
low=mid+1;
}
if(pos!=0)
cout<<"\nThe element you searched is "<<a[mid]<<" and is at position "<<pos<<endl;<br />
else
cout<<"\nThe element you were trying to search was not found !"<<endl;<br />
return 0;
}
Comments
-
The problem is here:
mid=low+high/2;
Since division has a higher precedence than addition, your code is equivalent to the following:mid = (low) + (high/2);
The program seems to work fine if you replace that line with this:mid=(low+high)/2;
Edit:
By the way, why is this posted under the category Installation and not under Software Development?0 -
jabirali wrote:
By the way, why is this posted under the category Installation and not under Software Development?[/quote]
I moved the discussion to the correct section.0 -
Well, thank you!0
-
#include<stdio.h>
#include<stdlib.h>
#include<malloc.h>
struct tree
{
int data ;
struct tree *left,*right;
}*root, *T=NULL;
typedef struct tree *node;
node insert(int,node t);
node FindMin(node t);
node del(int,node t);
void display(node t);
int main()
{
int item,n,i;
char c;
printf("\nenter the number of elemnets in tree..:");
scanf("%d",&n);
printf("\nenter the elements:\n");
for(i=1;i<=n;i++)
{
scanf("%d",&item);
T=insert(item,T);
}
printf("\nelements displayed in inorder:\n");
display(T);
printf("\nenter the elements to delete:\n");
scanf("%d",&item);
T=del(item,T);
printf("\ncontents of tree after deletion:\n");
display(T);
}
node insert(int x, node T)
{
struct tree *temp;
temp=malloc(sizeof(struct tree));
if(temp==NULL)
printf("\nout of space");
else
{
if(T==NULL)
{
temp->data=x;
temp->left=temp->right=NULL;
T=temp;
}
else
{
if(x<T->data)
T->left=insert(x,T->left);
else
T->right=insert(x,T->right);
}
}
return T;
}
node del(int x, node T)
{
node temp;
if(T==NULL)
printf("\nelement not found");
else
{
if(x<T->data)
T->left=del(x,T->left);
else
if(x>T->data)
T->right=del(x,T->right);
else
if(T->left && T->right)
{
temp=FindMin(T->right);
T->data=temp->data;
T->right=del(T->data,T->right);
}
else
{
temp=T;
if(T->left==NULL)
T=T->right;
else
if(T->right==NULL)
T=T->left;
free(temp);
}
}
return T;
}
node FindMin(node T)
{
if(T!=NULL)
{
if(T->left==NULL)
return T;
else
return FindMin(T->left);
}
}
void display(node T)
{
if(T!=NULL)
{
display(T->left);
printf("%d\n",T->data);
display(T->right);
}
}0
Categories
- 8.8K All Categories
- 13 LFX Mentorship
- 66 LFX Mentorship: Linux Kernel
- 355 Linux Foundation Boot Camps
- 228 Cloud Engineer Boot Camp
- 67 Advanced Cloud Engineer Boot Camp
- 23 DevOps Engineer Boot Camp
- 4 Cloud Native Developer Boot Camp
- 738 Training Courses
- 14 LFC110 Class Forum
- 16 LFD102 Class Forum
- 96 LFD103 Class Forum
- 2 LFD121 Class Forum
- 55 LFD201 Class Forum
- 1 LFD213 Class Forum - Discontinued
- 128 LFD232 Class Forum
- 14 LFD254 Class Forum
- 425 LFD259 Class Forum
- 78 LFD272 Class Forum
- 1 LFD272-JP クラス フォーラム
- 15 LFS200 Class Forum
- 686 LFS201 Class Forum
- LFS201-JP クラス フォーラム
- 271 LFS211 Class Forum
- 50 LFS216 Class Forum
- 23 LFS241 Class Forum
- 26 LFS242 Class Forum
- 18 LFS243 Class Forum
- 4 LFS244 Class Forum
- 7 LFS250 Class Forum
- LFS250-JP クラス フォーラム
- 105 LFS253 Class Forum
- 754 LFS258 Class Forum
- 7 LFS258-JP クラス フォーラム
- 48 LFS260 Class Forum
- 75 LFS261 Class Forum
- 6 LFS262 Class Forum
- 76 LFS263 Class Forum
- 14 LFS264 Class Forum
- 10 LFS266 Class Forum
- 8 LFS267 Class Forum
- 8 LFS268 Class Forum
- 5 LFS269 Class Forum
- 173 LFS272 Class Forum
- 1 LFS272-JP クラス フォーラム
- 184 LFW211 Class Forum
- 100 LFW212 Class Forum
- 876 Hardware
- 205 Drivers
- 74 I/O Devices
- 43 Monitors
- 115 Multimedia
- 204 Networking
- 98 Printers & Scanners
- 82 Storage
- 716 Linux Distributions
- 78 Debian
- 64 Fedora
- 12 Linux Mint
- 13 Mageia
- 22 openSUSE
- 125 Red Hat Enterprise
- 33 Slackware
- 13 SUSE Enterprise
- 344 Ubuntu
- 445 Linux System Administration
- 33 Cloud Computing
- 63 Command Line/Scripting
- Github systems admin projects
- 88 Linux Security
- 73 Network Management
- 105 System Management
- 45 Web Management
- 50 Mobile Computing
- 18 Android
- 19 Development
- 1.2K New to Linux
- 1.1K Getting Started with Linux
- 499 Off Topic
- 119 Introductions
- 193 Small Talk
- 19 Study Material
- 743 Programming and Development
- 237 Kernel Development
- 472 Software Development
- 899 Software
- 245 Applications
- 178 Command Line
- 2 Compiling/Installing
- 72 Games
- 313 Installation
- 19 All In Program
- 19 All In Forum
Upcoming Training
-
August 20, 2018
Kubernetes Administration (LFS458)
-
August 20, 2018
Linux System Administration (LFS301)
-
August 27, 2018
Open Source Virtualization (LFS462)
-
August 27, 2018
Linux Kernel Debugging and Security (LFD440)