HELP... error in my simple binary search program
Could any help me with a runtime error in my program?
In the program of binary search, I am not getting output if I choose my searching element more than the middle element.
Could anyone please help me to debug it?
#include
using namespace std;
int main()
{
int a[100],n,ele,mid,pos=0;
cout<<"\nEnter the number of elements you want to enter in an array: ";<br />
cin>>n;
cout<<"\nEnter the array: ";<br />
for(int i=0;i
cin>>a[i];
cout<<"\nEnter the element you want to search: ";<br />
cin>>ele;
int low=0,high=n-1;
while(low<=high)<br />
{
mid=low+high/2;
if(ele==a[mid])
{
pos=mid+1;
break;
}
else if(ele
high=mid-1;
else
low=mid+1;
}
if(pos!=0)
cout<<"\nThe element you searched is "<<a[mid]<<" and is at position "<<pos<<endl;<br />
else
cout<<"\nThe element you were trying to search was not found !"<<endl;<br />
return 0;
}
Comments
-
The problem is here:
mid=low+high/2;
Since division has a higher precedence than addition, your code is equivalent to the following:mid = (low) + (high/2);
The program seems to work fine if you replace that line with this:mid=(low+high)/2;
Edit:
By the way, why is this posted under the category Installation and not under Software Development?0 -
jabirali wrote:
By the way, why is this posted under the category Installation and not under Software Development? [/quote]
I moved the discussion to the correct section.0 -
Well, thank you!0
-
#include<stdio.h>
#include<stdlib.h>
#include<malloc.h>
struct tree
{
int data ;
struct tree *left,*right;
}*root, *T=NULL;
typedef struct tree *node;
node insert(int,node t);
node FindMin(node t);
node del(int,node t);
void display(node t);
int main()
{
int item,n,i;
char c;
printf("\nenter the number of elemnets in tree..:");
scanf("%d",&n);
printf("\nenter the elements:\n");
for(i=1;i<=n;i++)
{
scanf("%d",&item);
T=insert(item,T);
}
printf("\nelements displayed in inorder:\n");
display(T);
printf("\nenter the elements to delete:\n");
scanf("%d",&item);
T=del(item,T);
printf("\ncontents of tree after deletion:\n");
display(T);
}
node insert(int x, node T)
{
struct tree *temp;
temp=malloc(sizeof(struct tree));
if(temp==NULL)
printf("\nout of space");
else
{
if(T==NULL)
{
temp->data=x;
temp->left=temp->right=NULL;
T=temp;
}
else
{
if(x<T->data)
T->left=insert(x,T->left);
else
T->right=insert(x,T->right);
}
}
return T;
}
node del(int x, node T)
{
node temp;
if(T==NULL)
printf("\nelement not found");
else
{
if(x<T->data)
T->left=del(x,T->left);
else
if(x>T->data)
T->right=del(x,T->right);
else
if(T->left && T->right)
{
temp=FindMin(T->right);
T->data=temp->data;
T->right=del(T->data,T->right);
}
else
{
temp=T;
if(T->left==NULL)
T=T->right;
else
if(T->right==NULL)
T=T->left;
free(temp);
}
}
return T;
}
node FindMin(node T)
{
if(T!=NULL)
{
if(T->left==NULL)
return T;
else
return FindMin(T->left);
}
}
void display(node T)
{
if(T!=NULL)
{
display(T->left);
printf("%d\n",T->data);
display(T->right);
}
}0
Categories
- All Categories
- 112 LFX Mentorship
- 112 LFX Mentorship: Linux Kernel
- 604 Linux Foundation IT Professional Programs
- 315 Cloud Engineer IT Professional Program
- 139 Advanced Cloud Engineer IT Professional Program
- 52 DevOps Engineer IT Professional Program
- 67 Cloud Native Developer IT Professional Program
- 3 Express Training Courses
- 3 Express Courses - Discussion Forum
- 5.3K Training Courses
- 17 LFC110 Class Forum - Discontinued
- 8 LFC131 Class Forum
- 30 LFD102 Class Forum
- 178 LFD103 Class Forum
- LFD110 Class Forum
- 24 LFD121 Class Forum
- LFD133 Class Forum
- 2 LFD137 Class Forum
- 62 LFD201 Class Forum
- 2 LFD210 Class Forum
- 1 LFD210-CN Class Forum
- 1 LFD213 Class Forum - Discontinued
- 127 LFD232 Class Forum - Discontinued
- LFD233 Class Forum
- LFD237 Class Forum
- 22 LFD254 Class Forum
- 643 LFD259 Class Forum
- 107 LFD272 Class Forum
- 1 LFD272-JP クラス フォーラム
- 4 LFD273 Class Forum
- 1 LFS101 Class Forum
- LFS112 Class Forum
- LFS116 Class Forum
- LFS118 Class Forum
- LFS142 Class Forum
- LFS144 Class Forum
- 2 LFS145 Class Forum
- LFS146 Class Forum
- LFS151 Class Forum
- LFS157 Class Forum
- LFS158 Class Forum
- LFS162 Class Forum
- LFS167 Class Forum
- 28 LFS200 Class Forum
- 735 LFS201 Class Forum - Discontinued
- 1 LFS201-JP クラス フォーラム
- 13 LFS203 Class Forum
- 98 LFS207 Class Forum
- 299 LFS211 Class Forum
- 54 LFS216 Class Forum
- 47 LFS241 Class Forum
- 41 LFS242 Class Forum
- 36 LFS243 Class Forum
- 12 LFS244 Class Forum
- LFS245 Class Forum
- 41 LFS250 Class Forum
- 1 LFS250-JP クラス フォーラム
- LFS251 Class Forum
- 141 LFS253 Class Forum
- LFS254 Class Forum
- LFS255 Class Forum
- 2 LFS256 Class Forum
- LFS257 Class Forum
- 1.2K LFS258 Class Forum
- 9 LFS258-JP クラス フォーラム
- 109 LFS260 Class Forum
- 144 LFS261 Class Forum
- 39 LFS262 Class Forum
- 82 LFS263 Class Forum - Discontinued
- 15 LFS264 Class Forum - Discontinued
- 11 LFS266 Class Forum - Discontinued
- 20 LFS267 Class Forum
- 18 LFS268 Class Forum
- 26 LFS269 Class Forum
- 198 LFS272 Class Forum
- 1 LFS272-JP クラス フォーラム
- LFS274 Class Forum
- 3 LFS281 Class Forum
- 254 LFW211 Class Forum
- 173 LFW212 Class Forum
- 9 SKF100 Class Forum
- SKF200 Class Forum
- 781 Hardware
- 198 Drivers
- 68 I/O Devices
- 37 Monitors
- 95 Multimedia
- 174 Networking
- 87 Printers & Scanners
- 83 Storage
- 742 Linux Distributions
- 80 Debian
- 66 Fedora
- 15 Linux Mint
- 13 Mageia
- 23 openSUSE
- 143 Red Hat Enterprise
- 31 Slackware
- 13 SUSE Enterprise
- 347 Ubuntu
- 450 Linux System Administration
- 31 Cloud Computing
- 69 Command Line/Scripting
- Github systems admin projects
- 89 Linux Security
- 76 Network Management
- 101 System Management
- 46 Web Management
- 51 Mobile Computing
- 18 Android
- 23 Development
- 1.2K New to Linux
- 1K Getting Started with Linux
- 355 Off Topic
- 109 Introductions
- 167 Small Talk
- 18 Study Material
- 504 Programming and Development
- 283 Kernel Development
- 203 Software Development
- 844 Software
- 210 Applications
- 180 Command Line
- 3 Compiling/Installing
- 107 Games
- 308 Installation
- 51 All In Program
- 51 All In Forum
Upcoming Training
-
August 20, 2018
Kubernetes Administration (LFS458)
-
August 20, 2018
Linux System Administration (LFS301)
-
August 27, 2018
Open Source Virtualization (LFS462)
-
August 27, 2018
Linux Kernel Debugging and Security (LFD440)