Ch5, Lab 1 - validate running before server ready

the function should be async, then you wait until finished or maybe return a promise.

const data = require('../../data')
 
router.get('/', async (req, res) => {
  const randomString = await data();
  res.send(randomString)
})

@caphsob I've checked your code against validate.js and it seems to work just fine. This may be related to your host machine and there's perhaps a race condition. I'm going to update the start function in validate.js to:

async function start () {
  const server = net.createServer().listen()
  await once(server, 'listening')
  const { port } = server.address()
  server.close()
  await once(server, 'close')
  await writeFile(join(__dirname, 'model.js'), testingModel())
  const sp = spawn(process.platform === 'win32' ? 'npm.cmd' : 'npm', ['start'], { env: { ...process.env, PORT: port }, stdio: ['ignore', 'ignore', 'inherit'] })
  const [ err ] = await Promise.race([once(sp, 'spawn'), once(sp, 'error')])
 
  try {
    if (err) throw err
    await validate({ port })
  } catch (err) {
    if (err.code === 'ERR_ASSERTION') {
      console.log('⛔️ ' + err.message)
      process.exit(1)
    }
    throw err
  } finally {
    await writeFile(join(__dirname, 'model.js'), model())
    try { sp.kill() } catch {}
  }
}

This being the key line:

  const [ err ] = await Promise.race([once(sp, 'spawn'), once(sp, 'error')])

The spawn event was only added fairly recently, so this will be part of our major update to Node v16 (but you can try this out with Node 14/Node 16 and see if it works).

@jhonny111s avoid recommending async functions be used with Express, the training material goes into detail as to why this is a bad idea.

see my answer at

https://forum.linuxfoundation.org/discussion/861255/️-server-did-not-start-in-time-node-validate-js#latest

can you explain how to resolve GET http://localhost:3000/boat/02e9 must respond with 500 response? on validate.js

thanks

for me changing the node version to 16 worked.

I am unable to get the 500 error being handled. All the test cases on validation are successful but this. What could be the issue. Can someone help me out