0.6 Manipulating data Express async/await
hello @davidmarkclements ,
**I wonder if this statement from your course is still relevant
**
" ... using async/await with Express is recommended against. Express was built before async/await syntax was part of the JavaScript language and as a result it does not always behave as expected." source: https://trainingportal.linuxfoundation.org/learn/course/nodejs-services-development-lfw212/manipulating-data-with-restful-services/manipulating-data-with-restful-services?page=8
**I wondering in which case handling asynchronous code errors with try/catch will not work. Can you give me some examples?
**
I add one here that works and can not identify any use case where the try/catch block will not catch the error:
const express = require('express') const PORT = process.env.PORT || 3000; const app = express() app.use(express.json()); function foo() { return new Promise((resolve, reject) => { setTimeout(() => { reject(new Error('Rejection from promise foo function')) }, 2000); }) }; function errorHandler(req, res, next) { res.status( err.status || 500 ) .json({ error:'handled by errorHandler NOT from the try catch' }); } app.get('/', async (req, res, next) => { try { const result = await foo(); res.status(200).json(result); } catch (err) { res.status(404).json({ error: err.message }); } }); app.use(errorHandler) app.listen(PORT, () => console.log(`Server listening at PORT: ${PORT}`));
The above will catch the rejected Promise and handle the error from the promise.
Looking forward to your response. Thanks
Comments
-
hey @nayib - you've handled the case with a try/catch - as long as you do that it's fine. The problem is, it can be very easy to neglect to use a try/catch in an async route handler particularly when refactoring. e.g:
app.get('/', async (req, res) => { const result = await foo(); res.status(200).json(result); });
Also consider that multiple people may work on the same code base, and your chances of someone forgetting to try/catch increase significantly.
When that happens, promise rejections can be swallowed. When promise rejections are swallowed two unwanted things happen. 1. You get a memory leak. This is per the Promise spec, and the memory leak is internal to the JS engine, there is no way to clean that up. 2. Your application enters an unknown state, you have an error, it wasn't handled, you may not even know about it.
So essentially, it's a foot gun. Hopefully a future Express update will automatically check for promises and provide an integrated catch handler that converts promise rejections into HTTP errors - at the time of writing the material (and I think it's still the case) Express does not do that.
On a side note, in your code you set up an error handler and then manually handled the error, you're probably better off doing this per Express convention:
app.get('/', async (req, res, next) => { try { const result = await foo(); res.status(200).json(result); } catch (err) { err.status = err.status || 404 next(err) } });
0
Categories
- All Categories
- 60 LFX Mentorship
- 113 LFX Mentorship: Linux Kernel
- 618 Linux Foundation IT Professional Programs
- 321 Cloud Engineer IT Professional Program
- 142 Advanced Cloud Engineer IT Professional Program
- 55 DevOps Engineer IT Professional Program
- 68 Cloud Native Developer IT Professional Program
- 6 Express Training Courses
- 6 Express Courses - Discussion Forum
- 2.3K Training Courses
- 19 LFC110 Class Forum - Discontinued
- 9 LFC131 Class Forum
- 31 LFD102 Class Forum
- 175 LFD103 Class Forum
- 22 LFD121 Class Forum
- 2 LFD137 Class Forum
- 61 LFD201 Class Forum
- 2 LFD210 Class Forum
- 1 LFD210-CN Class Forum
- 1 LFD213 Class Forum - Discontinued
- 128 LFD232 Class Forum - Discontinued
- LFD237 Class Forum
- 23 LFD254 Class Forum
- 653 LFD259 Class Forum
- 108 LFD272 Class Forum
- 1 LFD272-JP クラス フォーラム
- 4 LFD273 Class Forum
- 2 LFS145 Class Forum
- 28 LFS200 Class Forum
- 740 LFS201 Class Forum - Discontinued
- 1 LFS201-JP クラス フォーラム
- 12 LFS203 Class Forum
- 92 LFS207 Class Forum
- 301 LFS211 Class Forum
- 54 LFS216 Class Forum
- 47 LFS241 Class Forum
- 41 LFS242 Class Forum
- 37 LFS243 Class Forum
- 12 LFS244 Class Forum
- 41 LFS250 Class Forum
- 1 LFS250-JP クラス フォーラム
- LFS251 Class Forum
- 142 LFS253 Class Forum
- LFS254 Class Forum
- LFS255 Class Forum
- LFS256 Class Forum
- LFS257 Class Forum
- 1.2K LFS258 Class Forum
- 10 LFS258-JP クラス フォーラム
- 106 LFS260 Class Forum
- 145 LFS261 Class Forum
- 39 LFS262 Class Forum
- 83 LFS263 Class Forum - Discontinued
- 15 LFS264 Class Forum - Discontinued
- 11 LFS266 Class Forum - Discontinued
- 20 LFS267 Class Forum
- 18 LFS268 Class Forum
- 26 LFS269 Class Forum
- 204 LFS272 Class Forum
- 1 LFS272-JP クラス フォーラム
- LFS274 Class Forum
- 3 LFS281 Class Forum
- 249 LFW211 Class Forum
- 177 LFW212 Class Forum
- 9 SKF100 Class Forum
- SKF200 Class Forum
- 907 Hardware
- 220 Drivers
- 74 I/O Devices
- 44 Monitors
- 116 Multimedia
- 210 Networking
- 102 Printers & Scanners
- 86 Storage
- 764 Linux Distributions
- 88 Debian
- 66 Fedora
- 15 Linux Mint
- 13 Mageia
- 24 openSUSE
- 143 Red Hat Enterprise
- 33 Slackware
- 13 SUSE Enterprise
- 357 Ubuntu
- 482 Linux System Administration
- 40 Cloud Computing
- 70 Command Line/Scripting
- Github systems admin projects
- 95 Linux Security
- 80 Network Management
- 108 System Management
- 51 Web Management
- 72 Mobile Computing
- 25 Android
- 32 Development
- 1.2K New to Linux
- 1.1K Getting Started with Linux
- 545 Off Topic
- 132 Introductions
- 223 Small Talk
- 22 Study Material
- 831 Programming and Development
- 282 Kernel Development
- 515 Software Development
- 974 Software
- 260 Applications
- 185 Command Line
- 3 Compiling/Installing
- 119 Games
- 318 Installation
- 65 All In Program
- 65 All In Forum
Upcoming Training
-
August 20, 2018
Kubernetes Administration (LFS458)
-
August 20, 2018
Linux System Administration (LFS301)
-
August 27, 2018
Open Source Virtualization (LFS462)
-
August 27, 2018
Linux Kernel Debugging and Security (LFD440)