read a directory and write the output into a file using streams

Hello,
As a small personal challenge i am trying to use streams for:
1.read a directory (__dirname in here)
2.transform the output as upperCase
3.write the transfomed output into a file
I found this solution, but i doubt that it is the best practice... May someone confirm ? or correct ?
const fs = require('fs') const { Transform, pipeline, Readable } = require('stream') const streamUpper = () => { return new Transform({ transform(chunk, enc, next) { next(null, chunk.toString().toUpperCase()) } }) } async function readDirStream() { const dir = await fs.promises.opendir(__dirname) for await (const dirent of dir) { await require('util').promisify(pipeline)( Readable.from(dirent.name+'\n'), streamUpper(), fs.createWriteStream('./fileList.txt', {flags:'a'}) ) } } readDirStream().catch(e => console.error(e))
Comments
-
I just notice that the Readable.from() (line 17) is useless, that is enought
await require('util').promisify(pipeline)( dirent.name+'\n', streamUpper(), fs.createWriteStream('./fileList.txt', {flags:'a'}) )
So it makes me try the course exemple "Reading Directories (.cont)", as there is the same Readable.from() consuming the output from opendir(). And it works without (Readable.from()) as well. I guess it makes sense as opendir() return already a stream, am i right ?
exemple from the course without Readable.from()
opendir(__dirname, (err, dir) => { if (err) { res.statusCode = 500 res.end('Server Error') return } // const dirStream = Readable.from(dir) const entryStream = createEntryStream() res.setHeader('Content-Type', 'application/json') pipeline(dir, entryStream, res, (err) => { if (err) console.error(err) }) })
0 -
- Avoid doing inline
require
- always putrequire
at the top Readable.from
is a convenient way to turn a data structure (string, array) into a readable stream- It's not needed in your directory processing example, and really neither is the transform stream
- A better example to use with your transform stream would be a TCP socket:
const { Transform, pipeline } = require('stream') const streamUpper = () => { return new Transform({ transform(chunk, enc, next) { next(null, chunk.toString().toUpperCase()) } }) } const { createServer } = require('net') createServer((socket) => { pipeline(socket, streamUpper(), socket, (err) => { if (err) console.error(err) else console.log('socket closed') }) }).listen(9999)
Readable.from
would be useful for testing your stream:const { Transform, Readable } = require('stream') const assert = require('assert').strict const streamUpper = () => { return new Transform({ transform(chunk, enc, next) { next(null, chunk.toString().toUpperCase()) } }) } const upper = streamUpper() Readable.from(['test-a', 'test-b']).pipe(upper) upper.once('data', (first) => { assert.equal(first, 'TEST-A') upper.once('data', (second) { assert.equal(first, 'TEST-B') }) })
1 - Avoid doing inline
-
Hello David,
Thank you for the answer, i will work on that. Thank you.
1
Categories
- 9.1K All Categories
- 15 LFX Mentorship
- 68 LFX Mentorship: Linux Kernel
- 380 Linux Foundation Boot Camps
- 233 Cloud Engineer Boot Camp
- 75 Advanced Cloud Engineer Boot Camp
- 30 DevOps Engineer Boot Camp
- 9 Cloud Native Developer Boot Camp
- 977 Training Courses
- 15 LFC110 Class Forum
- 16 LFD102 Class Forum
- 106 LFD103 Class Forum
- 6 LFD121 Class Forum
- 56 LFD201 Class Forum
- 1 LFD213 Class Forum - Discontinued
- 128 LFD232 Class Forum
- 19 LFD254 Class Forum
- 450 LFD259 Class Forum
- 90 LFD272 Class Forum
- 1 LFD272-JP クラス フォーラム
- 16 LFS200 Class Forum
- 713 LFS201 Class Forum
- LFS201-JP クラス フォーラム
- 282 LFS211 Class Forum
- 50 LFS216 Class Forum
- 27 LFS241 Class Forum
- 28 LFS242 Class Forum
- 19 LFS243 Class Forum
- 6 LFS244 Class Forum
- 12 LFS250 Class Forum
- LFS250-JP クラス フォーラム
- 113 LFS253 Class Forum
- 814 LFS258 Class Forum
- 8 LFS258-JP クラス フォーラム
- 54 LFS260 Class Forum
- 81 LFS261 Class Forum
- 18 LFS262 Class Forum
- 76 LFS263 Class Forum
- 14 LFS264 Class Forum
- 10 LFS266 Class Forum
- 10 LFS267 Class Forum
- 9 LFS268 Class Forum
- 6 LFS269 Class Forum
- 182 LFS272 Class Forum
- 1 LFS272-JP クラス フォーラム
- 191 LFW211 Class Forum
- 114 LFW212 Class Forum
- 880 Hardware
- 207 Drivers
- 74 I/O Devices
- 44 Monitors
- 115 Multimedia
- 205 Networking
- 98 Printers & Scanners
- 82 Storage
- 730 Linux Distributions
- 85 Debian
- 64 Fedora
- 12 Linux Mint
- 13 Mageia
- 22 openSUSE
- 127 Red Hat Enterprise
- 33 Slackware
- 13 SUSE Enterprise
- 349 Ubuntu
- 450 Linux System Administration
- 33 Cloud Computing
- 64 Command Line/Scripting
- Github systems admin projects
- 89 Linux Security
- 76 Network Management
- 105 System Management
- 45 Web Management
- 51 Mobile Computing
- 19 Android
- 19 Development
- 1.2K New to Linux
- 1.1K Getting Started with Linux
- 501 Off Topic
- 121 Introductions
- 193 Small Talk
- 19 Study Material
- 756 Programming and Development
- 243 Kernel Development
- 479 Software Development
- 903 Software
- 247 Applications
- 178 Command Line
- 2 Compiling/Installing
- 73 Games
- 314 Installation
- 26 All In Program
- 26 All In Forum
Upcoming Training
-
August 20, 2018
Kubernetes Administration (LFS458)
-
August 20, 2018
Linux System Administration (LFS301)
-
August 27, 2018
Open Source Virtualization (LFS462)
-
August 27, 2018
Linux Kernel Debugging and Security (LFD440)